fix: dodge Swift 6.3 SIL inliner crash on Onramp deinit#334
Merged
Conversation
TestFlight archive (Release -O) was crashing inside the SIL optimizer's EarlyPerfInliner pass — a Swift 6.3 compiler bug triggered when checking layout-constraint compatibility through the generic parameters of the @mainactor OnrampVerificationViewModel's isolated deinit. Marking the deinit @_optimize(none) skips the optimizer for just that function; runtime behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestFlight archive (Release
-O) offlipcash-1.11.0failed with a Swift compiler crash in theEarlyPerfInlinerpass onOnrampVerificationViewModel's isolated deinit (xcode-cloud build #421). Marking the deinit@_optimize(none)skips the SIL optimizer for just that function and works around the bug; runtime behavior is unchanged. This is cherry-picked fromfix/onramp-deinit-inliner-crashso it can ship independently of the contact-sync stack.Test plan: